Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting and filing and tidying userscripts in preparation for Slurm #15

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ikirker
Copy link
Contributor

@ikirker ikirker commented Oct 31, 2024

This is some prep work for adding Slurm capabilities, as well as making it easier to either work on or just get rid of major subsystems' scripts.

Since details of the Slurm implementation are not yet known (e.g. who will be an operator, details of intended user associations) there is still some placeholder stuff at the moment in createuser, and checkuser will need to be corrected if/when the design is finalised.

…ed scripts

This should make it easier to make the full switch later, and the module is being changed accordingly to make the PATHs still work.

I've done some checks, but it's *possible* something could break if it's using an absolute path to one of the relocated scripts.

Note that by "strongly associated", I mean "this is closely connected to a particular subsystem and would need to be wholly reimplemented for a new system if it's even still relevant".

The two removed scripts were for copying data on previous filesystem transitions, and are no longer relevant.
@ikirker
Copy link
Contributor Author

ikirker commented Oct 31, 2024

Oh, and, see the corresponding new userscripts modulefile: UCL-RITS/rcps-modulefiles@68b033b .

Copy link
Contributor

@heatherkellyucl heatherkellyucl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, I didn't hardcode paths for any of the MMM stuff that runs other scripts in here, so the cron loads the userscripts, and the python thomas- commands refer to createThomasuser without a full path, so shouldn't be affected by moving them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants